Skip to content

chore: update project version to 4.1.0-SNAPSHOT #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

chore: update project version to 4.1.0-SNAPSHOT #1557

merged 1 commit into from
Oct 25, 2022

Conversation

metacosm
Copy link
Collaborator

No description provided.

@metacosm metacosm self-assigned this Oct 19, 2022
@metacosm metacosm requested a review from csviri October 19, 2022 14:11
@csviri
Copy link
Collaborator

csviri commented Oct 20, 2022

This is fine, although it is not needed necessarily since the release changes the version.

@metacosm
Copy link
Collaborator Author

This is fine, although it is not needed necessarily since the release changes the version.

Not sure I follow what you mean but this is actually needed so that snapshot versions are actually coherent as there shouldn't be anymore 4.0.2-SNAPSHOT versions being built. For that matter, we should have changed the version earlier because some of these 4.0.2 snapshots were actually referring to what's in next while some others to what's in main…

@csviri
Copy link
Collaborator

csviri commented Oct 21, 2022 •
edited
Loading

This is fine, although it is not needed necessarily since the release changes the version.

Not sure I follow what you mean but this is actually needed so that snapshot versions are actually coherent as there shouldn't be anymore 4.0.2-SNAPSHOT versions being built. For that matter, we should have changed the version earlier because some of these 4.0.2 snapshots were actually referring to what's in next while some others to what's in main…

Ahh yes, sorry forgot that we have snapshots also from next

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

25.2% 25.2% Coverage
0.0% 0.0% Duplication

@metacosm metacosm merged commit 371c347 into next Oct 25, 2022
@metacosm metacosm deleted the update-version branch October 25, 2022 14:38
csviri pushed a commit that referenced this pull request Oct 28, 2022
@metacosm @csviri
chore: update project version to 4.1.0-SNAPSHOT (#1557)
a6ec369
csviri pushed a commit that referenced this pull request Oct 31, 2022
@metacosm @csviri
chore: update project version to 4.1.0-SNAPSHOT (#1557)
5256c53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metacosm @csviri