refactor: isolate bulk dependent resource handling more #1530
Conversation
metacosm
force-pushed
the
improve-bulk-2
branch
from
e5e2bf3 to
bfe3e67
Compare
There was a problem hiding this comment.
Went through this briefly, tbh I have mixed feelings. I agree that this is kinda more structured, but also was much harder to follow the flow of the execution, since bidirectional references etc. There are some parts that is not entirely clear for me, will take a deeper look on that tomorrow.
| } | ||
| } | ||
|
|
||
| private static class UpdatableBulkDependentResourceInstance<R, P extends HasMetadata> |
There was a problem hiding this comment.
I don't get why this is needed.
There was a problem hiding this comment.
This is needed so that we can have the exact same interface for a "single" or bulk dependent in AbstractDependentResource.
There was a problem hiding this comment.
More specifically, this is needed to be able to do this: https://github.com/java-operator-sdk/java-operator-sdk/pull/1530/files#diff-0d27f73ffef40826943dbbef3e9a2a1e74e2a10341627042ffa5a792d03c3638R39. In order to do it this way, the objects we iterate over need to be AbstractDependentResources.
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.