feat: external resource with generated id support #1527
Conversation
csviri
force-pushed
the
dependent-resource-with-persistent-state
branch
from
302b099 to
ec49d0f
Compare
| client.configMaps().resource(configMap).create(); | ||
|
|
||
| var primaryID = ResourceID.fromResource(resource); | ||
| configMapEventSource.handleRecentResourceCreate(primaryID, configMap); |
There was a problem hiding this comment.
This method shouldn't be called directly, imo. It shouldn't even be part of the public interface.
There was a problem hiding this comment.
In this case it is needed, since we want to be strongly consistent regarding the event source.
(For long term we might want to implement these features directly to the client, similarly as in go)
There was a problem hiding this comment.
Sure, but that's not up to the user to ensure that consistency. If the user has to enforce that, then we need to redesign things because the user shouldn't even be aware of that part as it's internal to how the SDK works.
There was a problem hiding this comment.
Dependent resources will hide this, but some might do it on lower level. The thing is that without that it just don't work, (In all cases). We need probably do some work on these levels in the future. But this is how it is now, hiding that layer would won't solve the problem. And dependent resources using that, as other abstractions might use that user implement itself, so definitelly would not hide it.
csviri
force-pushed
the
dependent-resource-with-persistent-state
branch
from
862b80b to
ddf29e9
Compare
csviri
changed the title
reconciler for IT fixes IT progress wp wip wip integration test javadoc
csviri
force-pushed
the
dependent-resource-with-persistent-state
branch
from
ddf29e9 to
7ce2800
Compare
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.