Skip to content

Mninor naming fixes #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Mninor naming fixes #1425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40538a5
feat: separate executor service for workflow
csviri Jul 25, 2022
2b7e625
thread naming
csviri Jul 25, 2022
cb5c713
fix: format
csviri Jul 25, 2022
ff2005c
fix: naming fixes
csviri Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ private void submitReconciliationExecution(ResourceState state) {
state.unMarkEventReceived();
metrics.reconcileCustomResource(state.getId(), state.getRetry(), metricsMetadata);
log.debug("Executing events for custom resource. Scope: {}", executionScope);
executor.execute(new ControllerExecution(executionScope));
executor.execute(new ReconcilerExecutor(executionScope));
} else {
log.debug(
"Skipping executing controller for resource id: {}. Controller in execution: {}. Latest Resource present: {}",
Expand Down Expand Up @@ -376,10 +376,10 @@ private void handleAlreadyMarkedEvents() {
}
}

private class ControllerExecution implements Runnable {
private class ReconcilerExecutor implements Runnable {
private final ExecutionScope<R> executionScope;

private ControllerExecution(ExecutionScope<R> executionScope) {
private ReconcilerExecutor(ExecutionScope<R> executionScope) {
this.executionScope = executionScope;
}

Expand All @@ -390,7 +390,7 @@ public void run() {
final var name = thread.getName();
try {
MDCUtils.addResourceInfo(executionScope.getResource());
thread.setName("EventHandler-" + controllerName);
thread.setName("ReconcilerExecutor-" + controllerName + "-" + thread.getId());
PostExecutionControl<R> postExecutionControl =
reconciliationDispatcher.handleExecution(executionScope);
eventProcessingFinished(executionScope, postExecutionControl);
Expand Down
2 changes: 1 addition & 1 deletion ...orsdk/operator/ControllerExecutionIT.java → ...torsdk/operator/ReconcilerExecutorIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.awaitility.Awaitility.await;

class ControllerExecutionIT {
class ReconcilerExecutorIT {

@RegisterExtension
LocallyRunOperatorExtension operator =
Expand Down