Skip to content

fix: improve ConfigurationServiceOverrider's resilience #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 26, 2022
Merged

fix: improve ConfigurationServiceOverrider's resilience #1420

merged 4 commits into from
Aug 26, 2022

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Aug 24, 2022 •
edited
Loading

  • fix: make it easier to support new field when overriding configuration
  • refactor: simplify constructors chaining

@metacosm metacosm self-assigned this Aug 24, 2022
@metacosm metacosm requested a review from csviri August 24, 2022 19:39
@metacosm metacosm force-pushed the fix-config-overrider branch from 4bc51b8 to 5470f61 Compare August 24, 2022 21:02
@metacosm metacosm force-pushed the fix-config-overrider branch from 007b369 to 3446bee Compare August 26, 2022 12:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

54.7% 54.7% Coverage
0.0% 0.0% Duplication

csviri
csviri approved these changes Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm merged commit d07b063 into next Aug 26, 2022
@metacosm metacosm deleted the fix-config-overrider branch August 26, 2022 17:42
csviri pushed a commit that referenced this pull request Aug 30, 2022
@metacosm @csviri
fix: improve ConfigurationServiceOverrider's resilience (#1420)
f2a9ffb
csviri pushed a commit that referenced this pull request Sep 5, 2022
@metacosm @csviri
fix: improve ConfigurationServiceOverrider's resilience (#1420)
e8c9cda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metacosm @csviri