fix: PerResourcePollingEventSource issue with resources #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
reviewed
Aug 23, 2022
| @@ -134,8 +134,8 @@ public final synchronized void registerEventSource(String name, EventSource even | |||
| @SuppressWarnings("unchecked") | |||
| public void broadcastOnResourceEvent(ResourceAction action, R resource, R oldResource) { | |||
| eventSources.additionalNamedEventSources().forEach(eventSource -> { | |||
| if (eventSource instanceof ResourceEventAware) { | |||
| var lifecycleAwareES = ((ResourceEventAware<R>) eventSource); | |||
| if (eventSource.original() instanceof ResourceEventAware) { | |||
There was a problem hiding this comment.
Are there possibly other spots where a similar change would be needed?
There was a problem hiding this comment.
Well, good question, probably not, since it works. Just this did not have a integration test.
metacosm
requested changes
Aug 23, 2022
| .build(); | ||
|
|
||
| @Test | ||
| void managedDependentsAreReconciledInOrder() { |
There was a problem hiding this comment.
This test name doesn't make sense…
| EventSourceContext<PerResourceEventSourceCustomResource> context) { | ||
| this.eventSource = | ||
| new PerResourcePollingEventSource<>(primaryResource -> { | ||
| numberOfFetchExecutions.addAndGet(1); |
There was a problem hiding this comment.
Wouldn't the test make more sense if it checked that it's actually called once per primary resource? Right now, it only checks the fetcher is called, not that it's called per resource.
There was a problem hiding this comment.
Yes, true, will improve the test.
csviri
force-pushed
the
perresource-it-and-fix
branch
from
0fed7d2 to
4c8a9b1
Compare
csviri
force-pushed
the
perresource-it-and-fix
branch
from
4c8a9b1 to
e085ba3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.