refactor: clean-up WorkflowReconcileResult and Condition

[metacosm]

• fix: grammar
• refactor: clean up WorkflowReconcileResult
• refactor: make it easier to create Conditions

[csviri]

TBH before it was more expressive before, kinda describing that what is there it is a special value - so presumably handled specially subsequently. Taking a look on this is little confusing? maybe document it?

[metacosm]

I don't think we lost any expressiveness with this change: the default is the non-instantiable interface so it fulfils the same role as a default value (i.e. we can effectively check that the provided value is not the default one) without the need to create an additional class.

[csviri]

Hmm, not sure, I mean VoidCondition has explicitly in it's name that it is about not having a condition. Byt fine by me also this way.

[metacosm]

The problem with VoidCondition is that it is still an implementation, meaning that if we somehow forget to check for it in the code that processes the annotation then you get a valid condition which is not what you want. Condition itself cannot be instantiated so if we don't process it, this will lead to a quick exception making it easier to figure out what is wrong as opposed to tracking down why some events are processed when they should not be because we forgot to check for VoidCondition somewhere.

[csviri]

Making VoidCondition abstract would help with that, since it would instantly fail. Also now it throws always an exception, so it will instantly recognized in any test something is wrong.

But again I'm fine with both, I like that there are no more dedicated classes, just needs to be documented that this is the intention putting the interface there as default, that is a good enough alternative for me :)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

61.7% Coverage
0.0% Duplication