Skip to content

feat: use fabric8 client json mapper by default #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022
Merged

feat: use fabric8 client json mapper by default #1382

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c63489c
feat: use fabric8 client json mapper by default
csviri Aug 2, 2022
cc485c9
refactor: remove constants to avoid mismatched configurations
metacosm Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import io.fabric8.kubernetes.api.model.HasMetadata;
import io.fabric8.kubernetes.client.Config;
import io.fabric8.kubernetes.client.CustomResource;
import io.fabric8.kubernetes.client.utils.Serialization;
import io.javaoperatorsdk.operator.api.monitoring.Metrics;
import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResourceFactory;
Expand Down Expand Up @@ -126,7 +127,7 @@ default boolean closeClientOnStop() {
}

default ObjectMapper getObjectMapper() {
return OBJECT_MAPPER;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the constant be removed altogether, as well, then?

return Serialization.jsonMapper();
}

default DependentResourceFactory dependentResourceFactory() {
Expand Down