Skip to content

feat: separate executor service for workflow #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 26, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jul 25, 2022

See related issue.

Todo:
Discuss what problem is ExecutorServiceManager is solving.

@csviri csviri self-assigned this Jul 25, 2022
@csviri csviri linked an issue Jul 25, 2022 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csviri
Copy link
Collaborator Author

csviri commented Jul 26, 2022

@metacosm let's discuss the concept first. (This is not urgent atm.)

@csviri csviri force-pushed the executor-service-for-workflow branch from 75dfd00 to cb5c713 Compare August 26, 2022 08:44
@csviri csviri changed the base branch from main to next August 26, 2022 08:45
@csviri csviri force-pushed the executor-service-for-workflow branch from cb5c713 to 9243906 Compare August 26, 2022 10:58
@csviri csviri marked this pull request as ready for review August 26, 2022 13:19
@csviri csviri requested a review from metacosm August 26, 2022 13:19
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm force-pushed the executor-service-for-workflow branch from 7603d03 to 9facd8f Compare August 26, 2022 19:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

54.5% 54.5% Coverage
0.0% 0.0% Duplication

@metacosm metacosm merged commit 80716a8 into next Aug 26, 2022
@metacosm metacosm deleted the executor-service-for-workflow branch August 26, 2022 20:03
csviri added a commit that referenced this pull request Aug 30, 2022
Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri added a commit that referenced this pull request Sep 5, 2022
Co-authored-by: Chris Laprun <metacosm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate Executor Service For Workflows
2 participants