Skip to content

refactor (#1327): Remove autoservice #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iocanel
Copy link
Collaborator

@iocanel iocanel commented Jul 11, 2022

The pull request removes google autoservice as a dependency.
Not 100% sure if this is what @csviri meant in #1327 but either way it's a small change that removes a compile time dependency. So win win.

Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri linked an issue Jul 11, 2022 that may be closed by this pull request
@csviri
Copy link
Collaborator

csviri commented Jul 11, 2022

Wow, yes, exactly what I mean, thx!
made just a small comment.

@iocanel iocanel force-pushed the 1327-remove-remove-autoservice branch from 12dbc1a to b4fd2c5 Compare July 12, 2022 07:32
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri merged commit a8c7fee into operator-framework:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on Guava (used just in Annotation Processing)
3 participants