-
Notifications
You must be signed in to change notification settings - Fork 220
feat: retry and retry configuration decoupling #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but this is a breaking change so we have to figure out when / how to introduce it…
To be honest, I think we should define what API's we cover under semver, (this might be one). But because of this would not introduce a next major version for sure. So would stick with 3.1 tbh. |
Will try to make it backwards compatible, and deprecate the old API. Then remove it in v4. |
I'm fine with sticking with 3.1 if it's too much trouble… Or this could wait for some later time… 🤷🏼 😀 |
Kudos, SonarCloud Quality Gate passed! |
No description provided.