Skip to content

feat: retry and retry configuration decoupling #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2022
Merged

feat: retry and retry configuration decoupling #1285

merged 3 commits into from
Jun 15, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jun 15, 2022

No description provided.

@csviri csviri self-assigned this Jun 15, 2022
@csviri csviri linked an issue Jun 15, 2022 that may be closed by this pull request
@csviri csviri requested a review from metacosm June 15, 2022 11:26
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this is a breaking change so we have to figure out when / how to introduce it…

@csviri
Copy link
Collaborator Author

csviri commented Jun 15, 2022

To be honest, I think we should define what API's we cover under semver, (this might be one). But because of this would not introduce a next major version for sure. So would stick with 3.1 tbh.

@csviri
Copy link
Collaborator Author

csviri commented Jun 15, 2022

Will try to make it backwards compatible, and deprecate the old API. Then remove it in v4.

@metacosm
Copy link
Collaborator

I'm fine with sticking with 3.1 if it's too much trouble… Or this could wait for some later time… 🤷🏼 😀

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 32 Code Smells

63.4% 63.4% Coverage
0.5% 0.5% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple RetryConfiguration from Retry
2 participants