aggregate exception improvement #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
requested changes
May 2, 2022
| private final List<Exception> causes; | ||
|
|
||
| public AggregatedOperatorException(String message, Exception... exceptions) { | ||
| super(message); | ||
| this.causes = exceptions != null ? Arrays.asList(exceptions) : Collections.emptyList(); | ||
| super(message, exceptions[0]); |
There was a problem hiding this comment.
This might NPE if no exception is passed.
There was a problem hiding this comment.
pushed with null check
| } | ||
|
|
||
| public AggregatedOperatorException(String message, List<Exception> exceptions) { | ||
| super(message); | ||
| this.causes = exceptions != null ? exceptions : Collections.emptyList(); | ||
| super(message, exceptions.get(0)); |
There was a problem hiding this comment.
Same, we need to check that the given parameter is not null…
metacosm
reviewed
May 2, 2022
|
|
||
| public class AggregatedOperatorException extends OperatorException { | ||
|
|
||
| private final List<Exception> causes; | ||
|
|
||
| public AggregatedOperatorException(String message, Exception... exceptions) { | ||
| super(message, exceptions[0]); | ||
| super(message, Objects.requireNonNull(exceptions)[0]); |
There was a problem hiding this comment.
That doesn't help, actually, since this still will throw an NPE if exceptions isn't present. With varargs, it's a definite possibility, though, granted, creating an AggregatedOperatorException and not passing any exceptions is probably expected to fail…
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding
toString. Adding the first exception as cause - maybe would be better to overrideprintStackTraceto handle the causes? RespectivelygetOurStackTraceinThrowableto have it nicer?