Skip to content

fix: make webpage sample work OOTB #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix: make webpage sample work OOTB #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sample-operators/webpage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ page. Otherwise you can change the service to a LoadBalancer (e.g on a public cl
You can also try to change the HTML code in `k8s/webpage.yaml` and do another `kubectl apply -f k8s/webpage.yaml`.
This should update the actual NGINX deployment with the new configuration.

Note that there are multiple reconciler implementations that watch `WebPage` resources differentiated by a label.
When you create a new `WebPage` resource, make sure its label matches the active reconciler's label selector.

If you want the Operator to be running as a deployment in your cluster, follow the below steps.

### Build
Expand Down
5 changes: 3 additions & 2 deletions sample-operators/webpage/k8s/webpage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
apiVersion: "sample.javaoperatorsdk/v1"
kind: WebPage
metadata:
labels:
low-level: "true"
# Use labels to match the resource with different reconciler implementations:
# labels:
# low-level: "true"
name: hellows
spec:
exposed: false
Expand Down