fix: naming and minor structural improvements #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
requested changes
Apr 4, 2022
.../main/java/io/javaoperatorsdk/operator/processing/event/source/SecondaryToPrimaryMapper.java
Outdated
Show resolved
Hide resolved
csviri
force-pushed
the
informer-improvements
branch
from
7679b62 to
cc377a8
Compare
metacosm
reviewed
Apr 5, 2022
| @@ -103,6 +103,6 @@ private void handleKubernetesClientException(Exception e) { | |||
|
|
|||
| @Override | |||
| public Optional<T> getSecondaryResource(T primary) { | |||
| return get(ResourceID.fromResource(primary)); | |||
| throw new IllegalStateException("This method should not be called here. Primary: " + primary); | |||
There was a problem hiding this comment.
It does not makes sense imo to ask for the secondary resource from the ControllerEventSource. It basically does not have secondary, so this operation should fail.
csviri
force-pushed
the
informer-improvements
branch
from
cc377a8 to
157d335
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.