refactor: configure spec directly instead of using public setter

Signed-off-by: Chris Laprun <claprun@redhat.com>

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java

@@ -228,9 +228,8 @@ private static List<DependentResourceSpec> dependentResources(
           eventSourceName);
 
       // extract potential configuration
-      final var configuration = DependentResourceConfigurationResolver
-          .extractConfigurationFromConfigured(spec, controllerConfiguration, dependentType);
-      spec.setConfiguration(configuration);
+      DependentResourceConfigurationResolver.configureSpecFromConfigured(spec, controllerConfiguration,
+          dependentType);
 
       specsMap.put(dependentName, spec);
     }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/dependent/DependentResourceConfigurationResolver.java

@@ -20,7 +20,7 @@ private DependentResourceConfigurationResolver() {}
       new HashMap<>();
 
 
-  public static <C extends ControllerConfiguration<?>> Object extractConfigurationFromConfigured(
+  public static <C extends ControllerConfiguration<?>> void configureSpecFromConfigured(
       DependentResourceSpec spec,
       C parentConfiguration,
       Class<? extends DependentResource> dependentResourceClass) {
@@ -30,7 +30,7 @@ public static <C extends ControllerConfiguration<?>> Object extractConfiguration
     if (converterAnnotationPair == null) {
       var configuredClassPair = getConfigured(dependentResourceClass);
       if (configuredClassPair == null) {
-        return null;
+        return;
       }
 
       // check if we already have a converter registered for the found Configured annotated class
@@ -54,8 +54,9 @@ public static <C extends ControllerConfiguration<?>> Object extractConfiguration
 
     // always called even if the annotation is null so that implementations can provide default
     // values
-    return converter.configFrom(configAnnotation, spec, parentConfiguration,
+    final var config = converter.configFrom(configAnnotation, spec, parentConfiguration,
         dependentResourceClass);
+    spec.setNullableConfiguration(config);
   }
 
   private static ConfiguredClassPair getConfigured(

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/dependent/DependentResourceSpec.java

@@ -104,7 +104,7 @@ public Optional<C> getConfiguration() {
     return Optional.ofNullable(nullableConfiguration);
   }
 
-  public void setConfiguration(C configuration) {
+  protected void setNullableConfiguration(C configuration) {
     this.nullableConfiguration = configuration;
   }
 }