Skip to content

Commit a29483f

Browse files
committed
test fix
Signed-off-by: Attila Mészáros <csviri@gmail.com>
1 parent 2ef4ba0 commit a29483f

File tree

3 files changed

+17
-16
lines changed

3 files changed

+17
-16
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ public boolean handleExceptionsInReconciler() {
195195
@SuppressWarnings({"unchecked", "rawtypes"})
196196
private static List<DependentResourceSpec> dependentResources(
197197
Workflow annotation,
198-
ControllerConfiguration<?> parent) {
198+
ControllerConfiguration<?> controllerConfiguration) {
199199
final var dependents = annotation.dependents();
200200

201201

@@ -214,7 +214,7 @@ private static List<DependentResourceSpec> dependentResources(
214214
"A DependentResource named '" + dependentName + "' already exists: " + spec);
215215
}
216216

217-
final var name = parent.getName();
217+
final var name = controllerConfiguration.getName();
218218

219219
var eventSourceName = dependent.useEventSourceWithName();
220220
eventSourceName = Constants.NO_VALUE_SET.equals(eventSourceName) ? null : eventSourceName;
@@ -229,7 +229,7 @@ private static List<DependentResourceSpec> dependentResources(
229229

230230
// extract potential configuration
231231
final var configuration = DependentResourceConfigurationResolver
232-
.extractConfigurationFromConfigured(spec, parent, dependentType);
232+
.extractConfigurationFromConfigured(spec, controllerConfiguration, dependentType);
233233
spec.setConfiguration(configuration);
234234

235235
specsMap.put(dependentName, spec);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/dependent/DependentResourceSpec.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public class DependentResourceSpec<R, P extends HasMetadata, C> {
2525
private final Condition<?, ?> activationCondition;
2626

2727
private final String useEventSourceWithName;
28-
private C nullableConfiguation;
28+
private C nullableConfiguration;
2929

3030
public DependentResourceSpec(Class<? extends DependentResource<R, P>> dependentResourceClass,
3131
String name, Set<String> dependsOn, Condition<?, ?> readyCondition,
@@ -101,10 +101,10 @@ public Optional<String> getUseEventSourceWithName() {
101101
}
102102

103103
public Optional<C> getConfiguration() {
104-
return Optional.ofNullable(nullableConfiguation);
104+
return Optional.ofNullable(nullableConfiguration);
105105
}
106106

107107
public void setConfiguration(C configuration) {
108-
this.nullableConfiguation = configuration;
108+
this.nullableConfiguration = configuration;
109109
}
110110
}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResourceConfigBuilder.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,16 @@ public KubernetesDependentResourceConfigBuilder<R> withInformerConfiguration(
3838
public KubernetesDependentResourceConfig<R> build() {
3939
return new KubernetesDependentResourceConfig<>(
4040
useSSA, createResourceOnlyIfNotExistingWithSSA,
41-
new InformerConfigSpec<R>(informerConfiguration.name(),
42-
informerConfiguration.getNamespaces(), informerConfiguration.getLabelSelector(),
43-
informerConfiguration.followControllerNamespaceChanges(),
44-
(OnAddFilter<R>) informerConfiguration.onAddFilter().orElse(null),
45-
(OnUpdateFilter<R>) informerConfiguration.onUpdateFilter().orElse(null),
46-
(OnDeleteFilter<R>) informerConfiguration.onDeleteFilter().orElse(null),
47-
(GenericFilter<R>) informerConfiguration.genericFilter().orElse(null),
48-
informerConfiguration.getGroupVersionKind().orElse(null),
49-
informerConfiguration.getSecondaryToPrimaryMapper(),
50-
informerConfiguration.getPrimaryToSecondaryMapper()));
41+
informerConfiguration == null ? null
42+
: new InformerConfigSpec<>(informerConfiguration.name(),
43+
informerConfiguration.getNamespaces(), informerConfiguration.getLabelSelector(),
44+
informerConfiguration.followControllerNamespaceChanges(),
45+
(OnAddFilter<R>) informerConfiguration.onAddFilter().orElse(null),
46+
(OnUpdateFilter<R>) informerConfiguration.onUpdateFilter().orElse(null),
47+
(OnDeleteFilter<R>) informerConfiguration.onDeleteFilter().orElse(null),
48+
(GenericFilter<R>) informerConfiguration.genericFilter().orElse(null),
49+
informerConfiguration.getGroupVersionKind().orElse(null),
50+
informerConfiguration.getSecondaryToPrimaryMapper(),
51+
informerConfiguration.getPrimaryToSecondaryMapper()));
5152
}
5253
}

0 commit comments

Comments
 (0)