Removed superfluous code from shdict_store #1956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed superfluous copy of key, and setting key_len and value_len.
zhuizhuhaomeng
approved these changes
Oct 28, 2021
doujiang24
approved these changes
Oct 29, 2021
doujiang24
pushed a commit
that referenced
this pull request
Oct 29, 2021
avoid setting the key_len, key_data and value_len fields since they already have the same values when replacing the value data.
|
Nice catch! Already merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed superfluous copy of key, and setting key_len and value_len.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.