bugfix: inlined Lua code snippets in nginx.conf failed to use the Lua… #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
reviewed
Feb 5, 2019
agentzh
force-pushed
the
inline-lua-cache-key-fix
branch
from
91b7f4d to
b2af4d3
Compare
|
@thibaultcha Yes. Hopefully we can migragte to the meta lua repo soon. |
thibaultcha
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… source checksum as part of the Lua code cache key. thanks Oleg A. Mamontov for the report in #1428.
Fix #1428.
optimize: now we exclude the current nginx config file info from the cache keys for inlined Lua code snippets in nginx config files.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.