Skip to content

Lacking the fix from #936 in the C API for lua-resty-core #1031

Closed
@agentzh

Description

@agentzh

Pull request #936 only contains the fix for the standard Lua API but not a fix in the pure C API for lua-resty-core.

Running lua-nginx-module's t/016-resp-header.t test file with lua-resty-core gives the following failures:

$ TEST_NGINX_INIT_BY_LUA="package.path = (package.path or '') .. '/usr/share/lua/5.1/?.lua;$PWD/../lua-resty-core/lib/?.lua;$PWD/../lua-resty-lrucache/lib/?.lua;' require 'resty.core'" prove -I../test-nginx/lib t/016-resp-header.t
t/016-resp-header.t .. 1/508 WARNING: TEST 3: set response content-type header - unexpected extra bytes after last chunk in response: "lo\x{0a}"
WARNING: TEST 3: set response content-type header - unexpected extra bytes after last chunk in response: "lo\x{0a}"
t/016-resp-header.t .. 58/508
#   Failed test 'TEST 69: return the matched content-type instead of default_type - response_body - response is expected (repeated req 0, req 0)'
#   at /home/agentzh/git/lua-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1382.
#          got: 'nil
# '
#     expected: 'image/png
# '

#   Failed test 'TEST 69: return the matched content-type instead of default_type - response_body - response is expected (repeated req 1, req 0)'
#   at /home/agentzh/git/lua-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1382.
#          got: 'nil
# '
#     expected: 'image/png
# '
t/016-resp-header.t .. 171/508
#   Failed test 'TEST 70: always return the matched content-type - response_body - response is expected (repeated req 0, req 0)'
#   at /home/agentzh/git/lua-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1382.
# @@ -1,2 +1,2 @@
# -image/png
# +nil
#  image/png

#   Failed test 'TEST 70: always return the matched content-type - response_body - response is expected (repeated req 1, req 0)'
#   at /home/agentzh/git/lua-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1382.
# @@ -1,2 +1,2 @@
# -image/png
# +nil
#  image/png
t/016-resp-header.t .. 404/508 # Looks like you failed 4 tests of 508.
t/016-resp-header.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/508 subtests

Test Summary Report
-------------------
t/016-resp-header.t (Wstat: 1024 Tests: 508 Failed: 4)
  Failed tests:  163, 167, 177, 181
  Non-zero exit status: 4
Files=1, Tests=508,  4 wallclock secs ( 0.08 usr  0.01 sys +  1.19 cusr  1.39 csys =  2.67 CPU)
Result: FAIL

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions