feat: log warning if old functions exist #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
Release-As: 4.0.0-beta.7
ascorbic
force-pushed
the
mk/old-func-check
branch
from
628955c to
2c31f06
Compare
tiffafoo
reviewed
Nov 16, 2021
tiffafoo
reviewed
Nov 16, 2021
test/index.js
Outdated
|
|
||
| expect(logMock).toHaveBeenCalledWith( | ||
| expect.stringContaining( | ||
| 'We have found the following functions in your site that seem to be left over from the old Next.js plugin.', |
There was a problem hiding this comment.
[sand] The test should probably contain the logged files too
tiffafoo
previously approved these changes
Nov 16, 2021
Co-authored-by: Tiffany Le-Nguyen <tiffany@netlify.com>
ascorbic
force-pushed
the
mk/old-func-check
branch
from
10f1645 to
e00bcaf
Compare
tiffafoo
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The old version of the plugin generated lots of functions which may be still lying around in users' sites, either checked-in to scm or just uncleaned in a build directory. These can cause errors and slow builds. This PR detects any functions called
next_*(which was the naming convention) and warns the user that they should delete them.Test plan
Create a function in the demo project, either in
.netlify/internal-functionsornetlify/functions, with a name starting withnext_. Run a build and note the warning.Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #772