-
Notifications
You must be signed in to change notification settings - Fork 89
chore: update issue and pr templates #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,22 @@ | ||
<!--Please tag yourself as the Assignee and at least one specific Ecosystem engineer as the Reviewer (@ascorbic, @lindsaylevine, @tiffanosaurus) --> | ||
<!--Please tag yourself as the Assignee and netlify/integrations as the Reviewer --> | ||
|
||
### Summary | ||
<!-- Provide a summary brief summary of the change. --> | ||
|
||
### Screenshots changes if applicable | ||
<!-- Please delete this section if not applicable to this PR. --> | ||
|
||
**Before:** | ||
|
||
**After:** | ||
<!-- Provide a brief summary of the change. --> | ||
|
||
### Test plan | ||
|
||
1. Visit the Deploy Preview ([insert link to specific page]()) | ||
... | ||
1. Visit the Deploy Preview ([insert link to specific page]()) ... | ||
|
||
### Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal (small picture) | ||
### Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal | ||
|
||
### Standard checks: | ||
|
||
<!-- Please delete any options that reviewers shouldn't check. --> | ||
|
||
- [ ] Check the Deploy Preview's Demo site for your PR's functionality | ||
- [ ] Add docs when necessary | ||
|
||
--- | ||
|
||
🧪 Once merged, make sure to update the version if needed and that it was published correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
# Markdown | ||
*.md | ||
|
||
# Logs | ||
logs | ||
*.log | ||
|
@@ -19,6 +16,5 @@ node_modules | |
.parcel-cache | ||
|
||
# Test | ||
demo | ||
lib | ||
tsconfig.json |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[dust] I don't really see a reason why we should ignore demo since it should automatically lint anyway 🤷♀️