feat: add docs on middleware #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
ascorbic
force-pushed
the
mk/middleware-docs
branch
from
4cd3894 to
96c6117
Compare
ascorbic
force-pushed
the
mk/middleware-docs
branch
from
96c6117 to
5270b1d
Compare
docs/middleware.md
Outdated
| @@ -0,0 +1,76 @@ | |||
| # Using Next 12 middleware on Netlify | |||
|
|
|||
| Next 12 introduces a new feature called [middleware](https://nextjs.org/docs/middleware), which are functions that are | |||
There was a problem hiding this comment.
Suggested change
| Next 12 introduces a new feature called [middleware](https://nextjs.org/docs/middleware), which are functions that are | |
| Next 12 introduces a new feature called [Middleware](https://nextjs.org/docs/middleware), which are functions that are |
There was a problem hiding this comment.
@MelanieCrissey Would the section title need to change too?
Using Next 12 Middleware on Netlify
Sounds like we're wanting it capitalized when it refers to the feature itself
tiffafoo
reviewed
Nov 12, 2021
docs/middleware.md
Outdated
| @@ -0,0 +1,76 @@ | |||
| # Using Next 12 middleware on Netlify | |||
|
|
|||
| Next 12 introduces a new feature called [middleware](https://nextjs.org/docs/middleware), which are functions that are | |||
There was a problem hiding this comment.
@MelanieCrissey Would the section title need to change too?
Using Next 12 Middleware on Netlify
Sounds like we're wanting it capitalized when it refers to the feature itself
Comment on lines
+12
to
+14
| Next 12 Middleware works out of the box with Netlify, and most functions will work unchanged. See | ||
| [the middleware docs](https://nextjs.org/docs/middleware) for details of how to create them. There are however a few | ||
| workarounds that are currently required for some features during the beta period: |
There was a problem hiding this comment.
Minor edits (assuming these are Netlify functions in the first line)
Suggested change
| Next 12 Middleware works out of the box with Netlify, and most functions will work unchanged. See | |
| [the middleware docs](https://nextjs.org/docs/middleware) for details of how to create them. There are however a few | |
| workarounds that are currently required for some features during the beta period: | |
| Next 12 Middleware works out of the box with Netlify, and most Netlify functions will work unchanged. Refer to | |
| [the middleware docs](https://nextjs.org/docs/middleware) for details of how to create middleware functions. There are, however, a few | |
| workarounds that are currently required for some features during the beta period: |
There was a problem hiding this comment.
No, these are middleware functions.
There was a problem hiding this comment.
it may be good to specify that - for extreme clarity 😄
Co-authored-by: Rachael Stavchansky <rachael@netlify.com>
rstavchansky
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds some docs on using Next 12 middleware on Netlify.
Rendered version
Fixes #775