fix: use forced catchall for preview mode #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
force-pushed
the
mk/cookie-static-redirects
branch
from
4f73cb2 to
58019e6
Compare
ascorbic
force-pushed
the
mk/cookie-static-redirects
branch
from
58019e6 to
6bb4cfe
Compare
Release-as: 4.0.0-beta.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For preview mode, instead of generating a forced redirect for every pre-rendered page, instead make the catch-all a forced redirect. This prevents the need to generate very large numbers of redirects.
Test plan
/previewTest. Check the message to see preview mode is disabled/api/enterPreview/previewTest, and check that preview mode is enabled./api/exitPreviewFixes #791