Skip to content

fix: switch to globby for static files #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix: switch to globby for static files #778

merged 1 commit into from
Nov 8, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Nov 8, 2021

Switch to globby rather than tiny-glob. The pattern fails as-is, but it supports separate negated globs which then work

Test plan

Note that tests pass on Windows

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal (small picture)

Fixes #776

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 8, 2021
@kodiakhq kodiakhq bot merged commit 1cc222a into main Nov 8, 2021
@kodiakhq kodiakhq bot deleted the mk/glob-fix branch November 8, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static file globs are broken on Windows
2 participants