feat: add support for persistent builders #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
ascorbic
force-pushed
the
feat/persistent-builders
branch
from
355f9de to
2e97091
Compare
lindsaylevine
approved these changes
Oct 15, 2021
| const HANDLER_FUNCTION_NAME = '___netlify-handler' | ||
| const ODB_FUNCTION_NAME = '___netlify-odb-handler' | ||
| const IMAGE_FUNCTION_NAME = '_ipx' | ||
| const ODB_PATH = destr(process.env.EXPERIMENTAL_PERSISTENT_BUILDERS) ? 'builders' : 'functions' |
There was a problem hiding this comment.
jw - why do we need destr here vs a truthy check?
There was a problem hiding this comment.
Because all env vars are strings if it's set to "false" or "0" it will be truthy
There was a problem hiding this comment.
Obviously this is unlikely in this case, but I do generally try to avoid simple truthy checks on env vars as it's so easy to have very confusing errors
ascorbic
force-pushed
the
feat/persistent-builders
branch
from
2e97091 to
c63669a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new builder persistence feature. It needs to be enabled for your org via feature flag, and then set the env var
EXPERIMENTAL_PERSISTENT_BUILDERS. This changes the path for ODBs