chore(deps): update dependency netlify-cli to ^5.2.11 #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
github-actions
bot
added
the
type: chore
renovate
bot
force-pushed
the
renovate/netlify-cli-5.x
branch
from
bd7842e to
763afe9
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/netlify-cli-5.x
branch
from
763afe9 to
b8e835c
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/netlify-cli-5.x
branch
from
b8e835c to
b3e3974
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/netlify-cli-5.x
branch
from
b3e3974 to
5a5b5db
Compare
renovate
bot
force-pushed
the
renovate/netlify-cli-5.x
branch
from
5a5b5db to
10d4ac3
Compare
ascorbic
approved these changes
Jul 29, 2021
serhalp
added a commit
that referenced
this pull request
Jun 13, 2024
* chore: remove unused deno.json field
When running deno, it warns that this is unused when also specifying `imports`.
* chore: fix type errors in Deno files
We weren't including Deno files in `tsc` typechecking, but we also weren't using any `deno` commands
that typecheck. This fixes obscured errors.
I wanted to introduce typechecking in CI in this commit, but it turned out harder than I expected,
so I've pulled that into a separate PR.
The JSON hack isn't great but really it's the whole "import a json and write new data to it" pattern
that should be simplified to "just read the new data in memory", since there's no actual reason to
write it to disk if you follow the code paths. It was just done that way because it was the shortest
path to add the dynamic fissue annotation from the previous implementation.
* chore(e2e-report): fix handling of skipped suites
Some parts of the code weren't correctly handling the case where an entire suite is skipped, with no
specific skipped tests specified.
1. The `testCount.skipped` before this fix was strangely the number of specifically skipped tests
plus the total number of suites which are either entirely skipped or contain skipped tests (i.e.
it was pretty wrong).
2. The computed `skipped` count within each test suite was also wrong but in a different way. It was
not counting at all skipped tests where the entire suite is skipped.
I've also commented some existing correct logic that is very unintuitive.
* chore(e2e): split open issues and skipped tests
It was really confusing, both as a person viewing the page, and as a developer working with the
code. This code and this component were muddling three different data types: failed tests, skipped
tests, and skipped test suites. It was really error prone and hard to follow and modify.
I've split this into separate components and sections on the page for failed tests ("open issues")
and skipped tests, and I've passed skipped tests and skipped suites separately into the latter
component.
I've also refactored some code with side effects to be easier to work with.
* refactor(e2e): remove stale todo
* chore(e2e): update e2e test-results.json fixture
This is the latest run on "latest" against main, from last night.
* chore: remove unused deno scripts
* chore(e2e): add test-results.json fixture to second path
We expect this in two different locations depending on the code path... Having a sample file here
allows for TypeScript to infer the type correctly.
* chore(e2e): add back some skipped tests we removed
The tests were named on canary, but we still need the old test names for `latest`.
* chore(e2e): fix bad skipped test name, skip 2 more
* chore(e2e): add missing tests to e2e-skip-retry.json
* chore(e2e): add one more skipped test
* chore(e2e): fix appending of skipped suites
It was appending entirely skipped suites AND partially skipped suites.
* chore(e2e): update test-results.json fixtures again
* chore(e2e): add sample issues.json for local dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^5.2.4->^5.2.11Release Notes
netlify/cli
v5.2.11Compare Source
v5.2.10Compare Source
v5.2.9Compare Source
v5.2.8Compare Source
v5.2.7Compare Source
v5.2.6Compare Source
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.