Skip to content

feat: use internal functions dir #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 3, 2021
Merged

feat: use internal functions dir #549

merged 4 commits into from
Aug 3, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jul 21, 2021

Use the new internal functions directory if available. If so, also warn if there are existing generated functions in the old directory that need removing.

Merging blocked by:

@ascorbic ascorbic requested a review from lindsaylevine July 21, 2021 15:54
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 21, 2021
@ascorbic ascorbic marked this pull request as draft July 21, 2021 16:34
@ascorbic ascorbic marked this pull request as ready for review August 2, 2021 12:29
@ascorbic ascorbic force-pushed the feat/internal-functions branch from a57a066 to e9f4d2d Compare August 2, 2021 12:31
@ascorbic ascorbic force-pushed the feat/internal-functions branch from e9f4d2d to f4c036d Compare August 3, 2021 14:09
@ascorbic ascorbic requested a review from lukeocodes August 3, 2021 14:47
Copy link

@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we love to see it

console.log(greenBright`• ${oldFunctions.join('\n• ')}
`)
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ascorbic ascorbic merged commit 1d2861b into main Aug 3, 2021
@ascorbic ascorbic deleted the feat/internal-functions branch August 3, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants