fix: handle empty publish directory #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
force-pushed
the
fix/default-publish-dir
branch
8 times, most recently
from
1c1fef9 to
796c576
Compare
ascorbic
force-pushed
the
fix/default-publish-dir
branch
from
796c576 to
dadc7fa
Compare
ascorbic
changed the title
serhalp
pushed a commit
that referenced
this pull request
Jun 13, 2024
Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if the publish dir was set to an empty string, then the plugin would think that the root of the Next site was a sibling of that, i.e. it was the directory above the repo root. This PR changes a few things. First, it adds specific handling for empty
PUBLISH_DIRandnetlifyConfig.build.publishvalues when running locally, as well as handling for when the publish dir is the site root. Ideally we'd fail if somebody sets the site root as the publish dir, like we do in the Gatsby plugin, but that would be a breaking change, so instead we work around it.This fixes the issue that broke some sites after 3.5.0 was released.