Fix failBuild() testing
#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
approved these changes
Nov 14, 2020
ascorbic
added a commit
that referenced
this pull request
Oct 5, 2021
* fix: include base static redirect for i18n sites too * fix: update snapshot
serhalp
pushed a commit
that referenced
this pull request
Apr 5, 2024
…res (#36) * fix: fixes an issue with next and npm workspaces on the testing fixtures * fix: issues from main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the hood,
utils.build.failBuild()is throwing an error.However, in tests, it is mocked with an empty function. This means the control flow continues because the code does not have any
returnstatement afterfailBuild(). This means tests end up in odd situation where they are reaching lines of code that should never been hit in production.This PR tries to fix this by:
returnstatements afterutils.build.failBuild()utils.build.failBuild(), replacing it with a simple function that throws an error. The tests then need to assert that an error is thrown from theasync onPreBuildfunction, which is done in Jest withawait expect(onPreBuild(...)).rejects.toThrow('error message'), as opposed to looking for mock calls.