Fix next.config.js resolution
#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
approved these changes
Nov 14, 2020
| `next.config.js must be one of: ${acceptableTargets.join(', ')}`, | ||
| ) | ||
| }) | ||
| test.each(['invalid_next_config', 'deep_invalid_next_config'])( |
| expect(utils.build.failBuild.mock.calls[0][0]).toEqual( | ||
| `next.config.js must be one of: ${acceptableTargets.join(', ')}`, | ||
| ) | ||
| }, |
There was a problem hiding this comment.
friendly reminder to update this with the new fixture and failBuild logic whenever you merge everything :) <3
ehmicky
force-pushed
the
bug/find-config
branch
from
379d6fd to
1d07505
Compare
ascorbic
added a commit
that referenced
this pull request
Oct 4, 2021
ascorbic
added a commit
that referenced
this pull request
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
In a monorepo setup, it is possible that
next.config.jsmight be in a parent directory if the user has set abasedirectory.Next.js is searching
next.config.jsin parent directories usingfind-up:https://github.com/vercel/next.js/blob/497cac4b93de9ecf6c7ed79bd6557dcd3bb51be5/packages/next/next-server/server/config.ts#L450
However we are not currently searching it in parent directories:
https://github.com/netlify/netlify-plugin-nextjs/blob/2849dc5f7c57e9fd827a939e067a871e4cb487b1/index.js#L57
Using
find-upshould fix this bug.This also adds a test for it.