feat: allow next middleware to use edge cache #2947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
added
the
type: feature
cshawaus
force-pushed
the
allow-next-middleware-cache
branch
2 times, most recently
from
e0c988c to
dbdf03e
Compare
cshawaus
force-pushed
the
allow-next-middleware-cache
branch
from
dbdf03e to
4f6232b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the Next.js middleware to use Edge caching as a configurable flag.
This is a beneficial feature for the Next.js middleware, and I cannot think of any reason why the Next.js Edge Function can't support it after patching and testing it in a real project with zero side effects.
In addition, sharing code between Next.js and vanilla Edge Functions can be very tricky, while having everything under one roof with caching capability simplifies the entire process.
Documentation
https://docs.netlify.com/edge-functions/optional-configuration/#response-caching
Tests
I have included a new fixture and integration test that toggles Edge caching on.
Relevant links (GitHub issues, etc.) or a picture of cute animal
n/a