Fix package.json validation
#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
approved these changes
Nov 13, 2020
ehmicky
force-pushed
the
bug/package-json
branch
from
a8334d0 to
a0dd873
Compare
ascorbic
pushed a commit
that referenced
this pull request
Oct 4, 2021
Co-authored-by: Renovate Bot <bot@renovateapp.com>
serhalp
pushed a commit
that referenced
this pull request
Apr 5, 2024
* chore: simplify get/remove prerendered content * chore: pin fastly module * chore: add a couple comments to storing of prerendered content * fix: avoid overawaiting when globbing * feat: add static pages content to CDN * fix: ensure json data is not bundled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22.
The line checks for
packageJsonbeing falsy:https://github.com/netlify/netlify-plugin-nextjs/blob/2849dc5f7c57e9fd827a939e067a871e4cb487b1/index.js#L21
However, when a site has no
package.json,packageJsonis an empty object. Therefore,Object.keys(packageJson).length === 0should be used instead.This PR also adds a test for it.