ci(e2e-report): support generating report site for version other than latest #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
commented
Jul 9, 2024
| rm e2e-report/data/test-results.json | ||
| gh run download ${{ steps.get-run-id.outputs.runId }} -n "latest-test-results.json" -D e2e-report/data/ --repo $GITHUB_REPOSITORY | ||
| version="${{ inputs.version }}" | ||
| version=${version:-latest} |
There was a problem hiding this comment.
we need a second layer of defaulting here because the scheduled run won't have the workflow_dispatch default populated
There was a problem hiding this comment.
True, but we can have it manual only just so we can do first release, and then fix this.
I don't think we're ready to automatically deploy on a schedule yet, in terms of test stability. Would be great to have a deploy preview automatically though (so then it's much easier to evaluate before manual release)
There was a problem hiding this comment.
To clarify for anyone reading this: this job already runs on a schedule and only ever creates deploy previews. We publish deploys to production manually in the Netlify UI.
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
serhalp
force-pushed
the
ci/read-correct-e2e-results-file
branch
from
ae2d3f2 to
045e12d
Compare
This replaces the hardcoded Next.js "latest" version with an optional selector input. While I was at it, I clarified some confusing aspects of this setup. It's tripped up multiple people already.
serhalp
force-pushed
the
ci/read-correct-e2e-results-file
branch
from
045e12d to
1aacb81
Compare
serhalp
changed the title
pieh
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the hardcoded Next.js "latest" version with an optional selector input.
While I was at it, I clarified some confusing aspects of this setup. It's tripped up multiple people already.
Documentation
N/A
Tests
When you make changes to a manual workflow setup, you can't see it reflected in the UI until you merge. However, I was able to use the GitHub CLI to manually trigger workflows against this branch's version of the workflow and it worked:
This resulted in these runs, respectively:
Relevant links (GitHub issues, etc.) or a picture of cute animal
N/A