chore: use netlify-cli as a regular dev dep #2484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of adding nondeterminism to our CI by installing netlify-cli@latest on each run, just install it as a regular dev dep and let Renovate handle bumps. In the case of the next.js repo e2e tests, reference this repo (which is guaranteed to be a sibling directory) to access the netlify-cli binary.
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
serhalp
added a commit
that referenced
this pull request
Oct 16, 2024
Ubuntu 24.04 (now ubuntu-latest) has removed the `netlify` CLI :( We were installing it manually in some CI workflows, but not the e2e report one, which started failing. This fixes that by pulling in the easy parts of #2484.
serhalp
added a commit
that referenced
this pull request
Oct 16, 2024
Ubuntu 24.04 (now ubuntu-latest) has removed the `netlify` CLI :( We were installing it manually in some CI workflows, but not the e2e report one, which started failing. This fixes that by pulling in the easy parts of #2484.
serhalp
added a commit
that referenced
this pull request
Oct 16, 2024
Ubuntu 24.04 (now ubuntu-latest) has removed the `netlify` CLI :( We were installing it manually in some CI workflows, but not the e2e report one, which started failing. This fixes that by pulling in the easy parts of #2484.
serhalp
added a commit
that referenced
this pull request
Oct 16, 2024
Ubuntu 24.04 (now ubuntu-latest) has removed the `netlify` CLI :( We were installing it manually in some CI workflows, but not the e2e report one, which started failing. This fixes that by pulling in the easy parts of #2484.
serhalp
added a commit
that referenced
this pull request
Oct 16, 2024
* chore(deps): use netlify-cli dev dep where possible Ubuntu 24.04 (now ubuntu-latest) has removed the `netlify` CLI :( We were installing it manually in some CI workflows, but not the e2e report one, which started failing. This fixes that by pulling in the easy parts of #2484. * ci: run next.js deps with netlify-cli dev dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of adding nondeterminism to our CI by installing netlify-cli@latest on each run, just install it as a regular dev dep and let Renovate handle bumps.
In the case of the next.js repo e2e tests, reference this repo (which is guaranteed to be a sibling directory) to access the netlify-cli binary.
Documentation
N/A
Tests
All tests passing is sufficient for this
Relevant links (GitHub issues, etc.) or a picture of cute animal
See https://github.com/netlify/next-runtime-minimal/pull/581 and follow the threads. This would have prevented that issue. This is also undoing that temporary workaround.