feat: implemented incremental cache #2288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for netlify-plugin-nextjs-next-auth-demo failed.
|
❌ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo failed.
|
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for next-plugin-edge-middleware failed.
|
❌ Deploy Preview for netlify-plugin-nextjs-static-root-demo failed.
|
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
❌ Deploy Preview for nextjs-plugin-custom-routes-demo failed.
|
❌ Deploy Preview for netlify-plugin-nextjs-demo failed.
|
nickytonline
commented
Aug 31, 2023
| @@ -0,0 +1,34 @@ | |||
| import type { Blobs } from '@netlify/blobs/dist/src/main' | |||
There was a problem hiding this comment.
This and memoize won't end up being part of this PR as they're already in #2287.
❌ Deploy Preview for netlify-plugin-nextjs-demo-all-flags failed.
|
nickytonline
commented
Sep 5, 2023
demos/default/next.config.js
Outdated
| @@ -89,5 +89,6 @@ module.exports = { | |||
| }, | |||
| experimental: { | |||
| optimizeCss: false, | |||
| incrementalCacheHandlerPath: require.resolve('./cache-handler.js'), | |||
There was a problem hiding this comment.
This won't be hard-coded. This is hard-coded for the moment for testing purposes. The real implementation will need to generate this and modify the Next.js config, pre-build.
demos/default/cache-handler.js
Outdated
| @@ -0,0 +1,19 @@ | |||
| const cache = new Map() | |||
There was a problem hiding this comment.
This uses an in memory cache for the moment for debugging purposes to see key and values in the cache.
Merged
nickytonline
changed the base branch from
main
to
nickytonline/blob-storage
nickytonline
force-pushed
the
nickytonline/incremental-cache
branch
from
fc7a91a to
f316e5f
Compare
|
I merged this branch into #2287. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal
Fixes
Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/568