fix: improves support for __NEXT_PRIVATE_PREBUNDLED_REACT #2236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
commented
Jul 28, 2023
| @@ -23,6 +23,10 @@ const getNetlifyNextServer = (NextServer: NextServerType) => { | |||
| private netlifyConfig: NetlifyConfig | |||
| private netlifyPrerenderManifest: PrerenderManifest | |||
|
|
|||
| public getAppRouterReactVersion(): string { | |||
There was a problem hiding this comment.
Added this public method so we can get the React version to set process.env.__NEXT_PRIVATE_PREBUNDLED_REACT if the request fails with [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './ server.edge' is not defined
taty2010
previously approved these changes
Jul 28, 2023
|
Gonna revisit this on Monday. I think I need to rerun the override hooks for this fix. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for lukas-next-runtime-demos-default failed.
|
orinokai
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Nice sleuthing, @taty2010 and thanks for all your work prior @nickytonline! Looks great to me.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves support for setting
__NEXT_PRIVATE_PREBUNDLED_REACT. We have an implementation that detects when to set__NEXT_PRIVATE_PREBUNDLED_REACTtoexperimentalbut there are edge cases. The fix is a naive approach where__NEXT_PRIVATE_PREBUNDLED_REACTis set toexperimentalif the request fails, and we reattempt the request.Documentation
Relates to https://github.com/netlify/pod-ecosystem-frameworks/issues/489
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal