fix: override headers within req.rewrite() #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kodiakhq merged 3 commits into main from tn-advMiddlewareRewriteInit

Jun 28, 2023

Contributor

taty2010 commented Jun 26, 2023 •

edited

Loading

Description

Based on the description provided here this update makes it to where we can now override the headers within the req.rewrite() like in the example below.

    const res = await request.rewrite('/static-rewrite',
    {
      headers: {
        'x-rewrite-test': 'hello',
        'x-rewrite-test-2': 'hello-2'
      }
    })

Documentation

Tests

You can test this change yourself like so:

Go to https://deploy-preview-2189--next-plugin-edge-middleware.netlify.app/request-rewrite
review the headers within the Network tab and should see the headers from the example code above.

Relevant links (GitHub issues, etc.) or a picture of cute animal


          fix: adding headers fix

5369c26

netlify bot commented Jun 26, 2023 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name	Link
🔨 Latest commit	`a0bbac6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/649c493ed733f60008d141d4
😎 Deploy Preview	https://deploy-preview-2189--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jun 26, 2023 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name	Link
🔨 Latest commit	`a0bbac6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/649c493e29cfc20007456c28
😎 Deploy Preview	https://deploy-preview-2189--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jun 26, 2023 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name	Link
🔨 Latest commit	`a0bbac6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/649c493e993df90008e7b081
😎 Deploy Preview	https://deploy-preview-2189--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions bot added the type: bug label

netlify bot commented Jun 26, 2023 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name	Link
🔨 Latest commit	`a0bbac6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/649c493e486bd0000720509e
😎 Deploy Preview	https://deploy-preview-2189--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jun 26, 2023 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name	Link
🔨 Latest commit	`a0bbac6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/649c493e42287d0008ec16f8
😎 Deploy Preview	https://deploy-preview-2189--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jun 26, 2023 •

edited

Loading

✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name	Link
🔨 Latest commit	`a0bbac6`
🔍 Latest deploy log	https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/649c493fac8601000858e109
😎 Deploy Preview	https://deploy-preview-2189--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jun 26, 2023 •

edited

Loading

✅ Deploy Preview for next-plugin-canary ready!

Name	Link
🔨 Latest commit	`a0bbac6`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-canary/deploys/649c493e5ecc340008e4082a
😎 Deploy Preview	https://deploy-preview-2189--next-plugin-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jun 26, 2023 •

edited

Loading

✅ Deploy Preview for next-i18next-demo ready!

Name	Link
🔨 Latest commit	`a0bbac6`
🔍 Latest deploy log	https://app.netlify.com/sites/next-i18next-demo/deploys/649c493eac8601000858e104
😎 Deploy Preview	https://deploy-preview-2189--next-i18next-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jun 26, 2023 •

edited

Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name	Link
🔨 Latest commit	`a0bbac6`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/649c493eb412580008d9601a
😎 Deploy Preview	https://deploy-preview-2189--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

taty2010 changed the title ~~fix: override headers/status within req.rewrite()~~ fix: override headers within req.rewrite()

taty2010 marked this pull request as ready for review

June 28, 2023 14:05

taty2010 requested a review from a team as a code owner

June 28, 2023 14:05


          Merge branch 'main' into tn-advMiddlewareRewriteInit

d80c931

MarcL reviewed

View reviewed changes

Contributor

MarcL left a comment

Think it just needs the test to be enabled and good to go.

cypress/e2e/middleware/enhanced.cy.ts Outdated Show resolved Hide resolved


          chore: remove skip

a0bbac6

nickytonline approved these changes

View reviewed changes

nickytonline left a comment

Looks good! 🚢

MarcL approved these changes

View reviewed changes

Contributor

MarcL left a comment

Thanks for the update. Looks great.

taty2010 added the automerge label

kodiakhq bot merged commit cc8546e into main

kodiakhq bot deleted the tn-advMiddlewareRewriteInit branch

June 28, 2023 20:50

token-generator-app bot mentioned this pull request

chore: release main #2192

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge type: bug