fix: Return MiddlewareResponse obj for rewrite #2159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
All the tests should be passing on this, there might have been an update recently with the app-dir tests. Will have to review once I'm back. |
| @@ -2,7 +2,7 @@ | |||
| import spawn from 'cross-spawn' | |||
| import { existsSync, readFileSync, unlinkSync, writeFileSync } from 'fs' | |||
| import { writeFile } from 'fs-extra' | |||
| import { fetch as undiciFetch } from 'undici' | |||
| import { fetch as undiciFetch } from 'next/dist/compiled/undici' | |||
There was a problem hiding this comment.
I guess we never figured out why the undici dep was no longer included?
There was a problem hiding this comment.
It happened here c295bc2
it got removed from package-lock but it looks like it was not set as a dep in the package.json.
There was a problem hiding this comment.
Once we move to Node.js 18, fetch is native, so this import won't be required.
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
update pageProps testing Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/510
We are now returning the MiddlewareResponse from the request.rewrite() instead of NextResponse. This will allow us to utilize the setPageProp and replaceText method.
This PR is to get the initial issue resolved, we will continue the work in another PR for the init parameter.
Documentation
Tests
This page should be rewritten with the cat ad and message with geo location
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal