fix: support named & default export for middleware in ntl dev #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| middleware = nextMiddleware.middleware | ||
|
|
||
| // The middleware file can export a named `middleware` export or a `default` export | ||
| middleware = isFunction(nextMiddleware.middleware) ? nextMiddleware.middleware : nextMiddleware.default |
There was a problem hiding this comment.
Is the function check necessary? I imagine nextMiddleware.middleware is undefined if the default exists?
Suggested change
| middleware = isFunction(nextMiddleware.middleware) ? nextMiddleware.middleware : nextMiddleware.default | |
| middleware = nextMiddleware.middleware ?? nextMiddleware.default |
There was a problem hiding this comment.
Someone could for some reason export a named middleware that is for them some utility. Better safe than sorry
pieh
approved these changes
May 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in amannn/next-intl#290 (comment) it seems that both a named
middlewareexport and adefaultexport is supported.This allows both for
netlify devwhen we import the middleware.Documentation
N/A
Tests
No tests were added but I tried the change manually on the repository shared in #2106
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal
Fixes #2106