Skip to content

[do-not-merge] just trying to run PR#2101 not through fork #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[do-not-merge] just trying to run PR#2101 not through fork #2103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d836b8
feat: support finding source file when index of folder
RohitRajendran May 11, 2023
66612f0
chore: add tests
RohitRajendran May 11, 2023
40a321d
fix: fix prettier error
RohitRajendran May 11, 2023
2b886a0
Update test/helpers/files.spec.ts
RohitRajendran May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/runtime/src/helpers/files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,11 @@ export const getSourceFileForPage = (page: string, roots: string[], pageExtensio
if (existsSync(file)) {
return file
}

const fileAtFolderIndex = join(root, page, `index.${extension}`)
if (existsSync(fileAtFolderIndex)) {
return fileAtFolderIndex
}
}
}
console.log('Could not find source file for page', page)
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/page-extensions/index/pages/api/index/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// noop
9 changes: 9 additions & 0 deletions test/helpers/files.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,4 +237,13 @@ describe('getSourceFileForPage', () => {

expect(filePath.replace(TEST_DIR, '')).toBe('/fixtures/page-extensions/custom/pages/api/custom.api.js')
})

it('handles getting file when index of folder', () => {
const pagesDir = resolve(__dirname, '../fixtures/page-extensions/index/pages')
const apiRoute = '/api/index'

const filePath = getSourceFileForPage(apiRoute, [pagesDir])

expect(filePath.replace(TEST_DIR, '')).toBe('/fixtures/page-extensions/index/pages/api/index/index.js')
})
})