chore: enable ESLint on test folder
#2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2 tasks
github-actions
bot
added
the
type: chore
nickytonline
approved these changes
May 2, 2023
There was a problem hiding this comment.
Looks good @LekoArts! Left some comments, but nothing blocking. 
| jestSetup.js | ||
| test/e2e | ||
| test/fixtures/broken_next_config/next.config.js |
There was a problem hiding this comment.
[dust] since we're updating this add a new line that's missing:
Comment on lines
+5
to
+10
| const netlifyConfig = { | ||
| build: { command: 'npm run build' }, | ||
| functions: {}, | ||
| redirects: [], | ||
| headers: [], | ||
| } as NetlifyPluginOptions['netlifyConfig'] |
There was a problem hiding this comment.
Maybe for another PR, but prefer not to cast. Add anything missing if required.
Suggested change
| const netlifyConfig = { | |
| build: { command: 'npm run build' }, | |
| functions: {}, | |
| redirects: [], | |
| headers: [], | |
| } as NetlifyPluginOptions['netlifyConfig'] | |
| const netlifyConfig: NetlifyPluginOptions['netlifyConfig'] = { | |
| build: { command: 'npm run build' }, | |
| functions: {}, | |
| redirects: [], | |
| headers: [], | |
| } |
There was a problem hiding this comment.
It seems that for the sake of the test, those key/values are enough, a lot of stuff is missing and it just unblocked things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables ESLint for our tests and adds
eslint-plugin-jestRelevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/466
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.