chore: Update to cypress v12 #2061
Conversation
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: chore
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -62,9 +62,9 @@ jobs: | |||
| headless: true | |||
| record: true | |||
| parallel: true | |||
| config-file: cypress/config/ci.json | |||
| config-file: cypress/config/ci.config.ts | |||
There was a problem hiding this comment.
Cypress config is now a JS or TS file. See https://docs.cypress.io/guides/references/configuration#Configuration-File
.github/workflows/cypress-canary.yml
Outdated
There was a problem hiding this comment.
If we're upgrading Cypress, I'd propose to also upgrade its GitHub action. We seem to currently use v2, while v5 is the latest: https://github.com/cypress-io/github-action/releases
There was a problem hiding this comment.
Glad you pointed that out looks like V2 was going to stop working after May
GitHub announced their plan to disable save-state and set-output commands by May 31, 2023. This will prevent cypress-io/github-action version v4.2.1, and earlier, running after this date since they use set-output. Affected users should update to using v5 of the cypress-io/github-action action before the deadline.
Co-authored-by: Lennart <lekoarts@gmail.com>
|
Just FYI: This PR made the integration tests in Or we use a composite action, so that all the configuration can be shared with zisi: https://wallis.dev/blog/composite-github-actions |
Summary
This PR updates our tests from cypress v9 to v12 Migration Docs
closes https://github.com/netlify/pod-ecosystem-frameworks/issues/333
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.