Skip to content

chore: test reorganization #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 20, 2023
Merged

chore: test reorganization #2054

merged 15 commits into from
Apr 20, 2023

Conversation

LekoArts
Copy link

@LekoArts LekoArts commented Apr 19, 2023

Summary

Reorganize our tests. Things done:

  • Most files are organized in a folder structure, e.g. packages/runtime/src/helpers/analysis. This moves all tests files into the same hierarchy/folder structure inside the test folder
  • Move common utilities for tests from index.spec.js to a test-utils.ts file
  • Convert index.spec.js to TS
  • Move tests of helpers from index.spec.js to individual files
  • Create a describeCwdTmpDir helper to run cwd in a tmpDir more easily

Test plan

All tests should still behave as before.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/455

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 910be7a
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6440dc011d773c0008f7e6b4
😎 Deploy Preview https://deploy-preview-2054--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 910be7a
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6440dc01fa9d1e000887db6e
😎 Deploy Preview https://deploy-preview-2054--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Apr 19, 2023
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 910be7a
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6440dc01581f3c000870ef9d
😎 Deploy Preview https://deploy-preview-2054--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 910be7a
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/6440dc014606aa0007b25fa0
😎 Deploy Preview https://deploy-preview-2054--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 910be7a
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/6440dc014560510008c27d73
😎 Deploy Preview https://deploy-preview-2054--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 910be7a
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6440dc0178ea4e000856870d
😎 Deploy Preview https://deploy-preview-2054--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 910be7a
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/6440dc011d773c0008f7e6b9
😎 Deploy Preview https://deploy-preview-2054--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 910be7a
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/6440dc01a25e350008e77ec3
😎 Deploy Preview https://deploy-preview-2054--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 910be7a
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/6440dc01ef3aab0007162f6e
😎 Deploy Preview https://deploy-preview-2054--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LekoArts LekoArts marked this pull request as ready for review April 19, 2023 12:28
@LekoArts LekoArts requested a review from a team April 19, 2023 12:28
Copy link
Contributor

@orinokai orinokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a great improvement! Anything we can do to make this huge index.spec.ts more readable is a huge win. Thanks @LekoArts.

@LekoArts LekoArts merged commit a37fb72 into main Apr 20, 2023
@LekoArts LekoArts deleted the test-reorganization branch April 20, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants