-
Notifications
You must be signed in to change notification settings - Fork 89
fix: correctly match params in edge runtime #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b77d590
fix: match params for edge runtime
ascorbic 0136641
chore: re-enable test
ascorbic 4c7affb
chore: snapidoo
ascorbic 9d45439
chore: disable rewrite tests
ascorbic 205b8ff
Merge branch 'main' into mk/edge-match-path
ascorbic 1d868c7
chore: enable more tests
ascorbic b29c636
fix: match ef data routes
ascorbic 0b9dbb3
chore: add comments
ascorbic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
export const config = { | ||
runtime: 'experimental-edge', | ||
} | ||
|
||
export default function Page(props) { | ||
return ( | ||
<> | ||
<p id="page">/edge/[id]</p> | ||
<p id="props">{JSON.stringify(props)}</p> | ||
</> | ||
) | ||
} | ||
|
||
export function getServerSideProps({ req, params, query }) { | ||
return { | ||
props: { | ||
url: req.url, | ||
query, | ||
params, | ||
now: Date.now(), | ||
}, | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
/** | ||
* This placeholder is replaced with the compiled Next.js bundle at build time | ||
* @param {Object} props | ||
* @param {import("./runtime.ts").RequestData} props.request | ||
* @param {import("./function-runtime.ts").RequestData} props.request | ||
* @returns {Promise<import("../edge-shared/utils.ts").FetchEventResult>} | ||
*/ | ||
export default async ({ request }) => {} | ||
export const _DEFINITION = { env: [], files: [], page: 'placeholder', name: 'pages_placeholder', matchers: [] } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.