-
Notifications
You must be signed in to change notification settings - Fork 89
fix: add longitude, latitude, and timezone to RequestData.geo #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+48
−6
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
949689a
fix: add longitude, latitude to RequestData.geo
nickytonline ac259b4
chore: removed setting a header for timezone as Next.js doesn't provi…
nickytonline 84be541
Merge remote-tracking branch 'origin/main' into nickytonline/add-long…
nickytonline 223937f
Merge branch 'main' into nickytonline/add-long-lat-to-geo
nickytonline aa59d03
chore: added timezone to geo data
nickytonline 42381b7
test: updated geo test for request
nickytonline f3af4ad
chore: imported correct NextRequest type
nickytonline fcf020f
chore: removed unused import
nickytonline b658c0c
chore: updated api route for geo test
nickytonline 4d0801f
chore: cleaned up NextRequest type
nickytonline 36c0835
Merge branch 'main' into nickytonline/add-long-lat-to-geo
nickytonline File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export default function handler(req, res) { | ||
res.status(200).json({ name: 'geo-test', headers: req.headers }) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ export interface RequestData { | |
region?: string | ||
latitude?: string | ||
longitude?: string | ||
timezone?: string | ||
} | ||
headers: Record<string, string> | ||
ip?: string | ||
|
@@ -63,10 +64,13 @@ const handler = async (req: Request, context: Context) => { | |
return | ||
} | ||
|
||
const geo = { | ||
const geo: RequestData['geo'] = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yay type! |
||
country: context.geo.country?.code, | ||
region: context.geo.subdivision?.code, | ||
city: context.geo.city, | ||
latitude: context.geo.latitude?.toString(), | ||
nickytonline marked this conversation as resolved.
Show resolved
Hide resolved
|
||
longitude: context.geo.longitude?.toString(), | ||
timezone: context.geo.timezone, | ||
} | ||
|
||
const requestId = req.headers.get('x-nf-request-id') | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.