chore(deps): upgrade everything to latest Next and React #1775
Conversation
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: chore
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for nextjs-plugin-next-11-demo failed.
|
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Something is up with the API route dependency resolution |
ascorbic
force-pushed
the
mk/next-13-0-3
branch
from
62e70b6 to
0e5e578
Compare
ascorbic
force-pushed
the
mk/next-13-0-3
branch
3 times, most recently
from
1600ce7 to
568145b
Compare
ascorbic
force-pushed
the
mk/next-13-0-3
branch
from
568145b to
a46fe05
Compare
| @@ -5,7 +5,6 @@ ignore = "if [ $CACHED_COMMIT_REF == $COMMIT_REF ]; then (exit 1); else git diff | |||
|
|
|||
| [build.environment] | |||
| TERM = "xterm" | |||
| NODE_VERSION = "17" | |||
There was a problem hiding this comment.
Is this safe to remove? I can't remember why we had this set.
There was a problem hiding this comment.
It was for Cypress. It caused breakages with this update, as there are packages with engines fields that don't like it. It didn't seem to be needed anymore, and the tests still pass.
| @@ -5,7 +5,6 @@ ignore = "if [ $CACHED_COMMIT_REF == $COMMIT_REF ]; then (exit 1); else git diff | |||
|
|
|||
| [build.environment] | |||
| NETLIFY_NEXT_PLUGIN_SKIP = "true" | |||
| NODE_VERSION = "17" | |||
| @@ -1,6 +1,6 @@ | |||
| import Chance from 'chance' | |||
| import { NextURL } from 'next/dist/server/web/next-url' | |||
| import { NextCookies } from 'next/dist/server/web/spec-extension/cookies' | |||
| import { RequestCookies } from 'next/dist/server/web/spec-extension/cookies' | |||
There was a problem hiding this comment.
Is this to fixe the RespsonseCookies.getAll()?
There was a problem hiding this comment.
@nickytonline No, this is related to changes in Next 13, where they switched from a single NextCookies class into separate RequestCookies and ResponseCookies classes
| @@ -356,7 +356,7 @@ export const getDependenciesOfFile = async (file: string) => { | |||
| return [] | |||
| } | |||
| const dependencies = await readJson(nft, 'utf8') | |||
| return dependencies.files.map((dep) => resolve(file, dep)) | |||
| return dependencies.files.map((dep) => resolve(dirname(file), dep)) | |||
There was a problem hiding this comment.
This fixes the tests, i.e. snapshots below, but do we have something in place to test this aside from the snapshot?
There was a problem hiding this comment.
@nickytonline I added tests in #1780, which is a more comprehensive fix
Summary
Manually upgrades demo sites and packages to Next 13.0.3 and React 18.2.0. Fixes a unit test broken by this.
Test plan
Check it all builds ok
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.