Skip to content

feat: ✨ change over to next-runtime #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 17, 2022
Merged

feat: ✨ change over to next-runtime #1540

merged 7 commits into from
Aug 17, 2022

Conversation

ericapisani
Copy link

@ericapisani ericapisani commented Aug 16, 2022

Summary

Change over to next-runtime.

There's still some references to plugin-nextjs in some of the package locks for the demo sties, I think those will need to be fixed once the initial package of next-runtime is released (since the error right now for those relate to not being able to find the package in the npm registry)

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Github issue
let's do this

@ericapisani ericapisani added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Aug 16, 2022
@ericapisani ericapisani self-assigned this Aug 16, 2022
@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit b25d8f8
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/62fcdb1f318f000008f1963c
😎 Deploy Preview https://deploy-preview-1540--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62fcdc1f197a6d1be3022a08
😎 Deploy Preview https://deploy-preview-1540--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit b25d8f8
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62fcdb1f62b6c50008845cac
😎 Deploy Preview https://deploy-preview-1540--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ericapisani ericapisani changed the title ✨ feat: change over to next-runtime feat: ✨ change over to next-runtime Aug 16, 2022
@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62fce26379853b00a841d66b
😎 Deploy Preview https://deploy-preview-1540--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62fce1cd197a6d2031022b21
😎 Deploy Preview https://deploy-preview-1540--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit b25d8f8
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62fcdb1fe4f02b000868ffac
😎 Deploy Preview https://deploy-preview-1540--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62fce1adc57d430e333f6d4e
😎 Deploy Preview https://deploy-preview-1540--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/62fce19179853b005f41d2e9
😎 Deploy Preview https://deploy-preview-1540--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit b25d8f8
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62fcdb1f8a43d80008ce1833
😎 Deploy Preview https://deploy-preview-1540--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit b25d8f8
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62fcdb1f9e87500008207893
😎 Deploy Preview https://deploy-preview-1540--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62fce169ce2be4009f678eed

@ericapisani ericapisani marked this pull request as ready for review August 16, 2022 16:05
@ericapisani ericapisani requested a review from a team August 16, 2022 16:05
@ascorbic
Copy link
Contributor

If you run npm install in the monorepo, it should update the lockfiles without it needing to be published. It can see the package is in the workspace.

@ericapisani
Copy link
Author

@ascorbic I had done that but for some odd reason some are working and others aren't. As an example - the default demo installs correctly while the next-auth one fails (even after removing the package-lock.json file within next-auth as well) 🤔 Perhaps I just need to dig a little more into this

Screen Shot 2022-08-16 at 12 41 18 PM

update package lock files
@ericapisani
Copy link
Author

@ascorbic I found the issue - we forgot to add the next-auth project to the workspaces list when we transitioned to it a while back 😅

@ascorbic
Copy link
Contributor

Well spotted!

Copy link

@sarahetter sarahetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 7ecf41d into main Aug 17, 2022
@kodiakhq kodiakhq bot deleted the ep/rename branch August 17, 2022 13:25
This was referenced Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants