chore: move middleware support into separate package #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kodiakhq merged 4 commits into main from mk/middleware-package

Aug 12, 2022

Contributor

ascorbic commented Aug 12, 2022 •

edited

Loading

Summary

Moves the middleware support from the build plugin into a new @netlify/next package.

Test plan

Visit the preview for the middleware demo, and ensure that the examples all work

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

Check the Deploy Preview's Demo site for your PR's functionality
Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

github-actions bot added the type: chore label

ascorbic changed the base branch from mk/move-plugin to main

August 12, 2022 10:57

ascorbic changed the base branch from main to mk/move-plugin

August 12, 2022 10:58

Base automatically changed from mk/move-plugin to main

August 12, 2022 11:02

ascorbic force-pushed the mk/middleware-package branch from 7550fab to 1b6e65c Compare

August 12, 2022 11:04

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-hp-edge-demo ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/next-hp-edge-demo/deploys/62f666f8bff9fd00081b38a6
😎 Deploy Preview	https://deploy-preview-1520--next-hp-edge-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62f666f8bff9fd00081b389c
😎 Deploy Preview	https://deploy-preview-1520--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62f666f881ca860009487187
😎 Deploy Preview	https://deploy-preview-1520--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62f666f8380a820008a17544
😎 Deploy Preview	https://deploy-preview-1520--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-plugin-rsc-demo ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62f666f8bff9fd00081b38a1
😎 Deploy Preview	https://deploy-preview-1520--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-plugin-canary ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-canary/deploys/62f666f8ef99fa00094900ed
😎 Deploy Preview	https://deploy-preview-1520--next-plugin-canary.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-i18next-demo ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/next-i18next-demo/deploys/62f666f89ae1f800088a9ec4
😎 Deploy Preview	https://deploy-preview-1520--next-i18next-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/62f666f845f9840008ef6264
😎 Deploy Preview	https://deploy-preview-1520--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62f666f8d5dc2700091bb237
😎 Deploy Preview	https://deploy-preview-1520--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62f666f8eb92200008cb9ebc
😎 Deploy Preview	https://deploy-preview-1520--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name	Link
🔨 Latest commit	`2d11183`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62f666f8380a820008a17549
😎 Deploy Preview	https://deploy-preview-1520--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cypress bot commented Aug 12, 2022 •

edited

Loading

Test summary

7 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-static-demo
Status	Passed
Commit	`2352f7b` ℹ️
Started	Aug 12, 2022 2:40 PM
Ended	Aug 12, 2022 2:41 PM
Duration	01:16 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress bot commented Aug 12, 2022 •

edited

Loading

Test summary

22 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-default-demo
Status	Passed
Commit	`2352f7b` ℹ️
Started	Aug 12, 2022 2:40 PM
Ended	Aug 12, 2022 2:41 PM
Duration	01:25 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress bot commented Aug 12, 2022 •

edited

Loading

Test summary

2 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-nx-monorepo-demo
Status	Passed
Commit	`2352f7b` ℹ️
Started	Aug 12, 2022 2:41 PM
Ended	Aug 12, 2022 2:42 PM
Duration	01:11 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

ascorbic marked this pull request as ready for review

August 12, 2022 11:13

ascorbic requested a review from a team

August 12, 2022 11:13


          chore: move middleware support into separate package

af037f6

ascorbic force-pushed the mk/middleware-package branch from 1b6e65c to af037f6 Compare

August 12, 2022 11:55


          chore: add build command

789a8f1

ascorbic self-assigned this

ericapisani previously approved these changes

View reviewed changes


          ci: update release please to publish more packages

692ea63

ascorbic dismissed ericapisani’s stale review via

692ea63

August 12, 2022 14:36

ascorbic requested a review from ericapisani

August 12, 2022 14:37

ericapisani approved these changes

View reviewed changes

ascorbic added the automerge label


          Merge branch 'main' into mk/middleware-package

2d11183

kodiakhq bot merged commit fbb52a4 into main

kodiakhq bot deleted the mk/middleware-package branch

August 12, 2022 14:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge type: chore