Skip to content

chore: move plugin package into packages/* directory #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2022
Merged

chore: move plugin package into packages/* directory #1518

merged 4 commits into from
Aug 12, 2022

Conversation

ascorbic
Copy link
Contributor

Summary

In preparation for adding more packages, move plugin package into packages subdirectory

Test plan

  1. Ensure deploy previews build and tests pass

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

smol capybara

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@ascorbic ascorbic requested a review from a team August 12, 2022 09:47
@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/62f632d24e74f10009c3b897
😎 Deploy Preview https://deploy-preview-1518--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62f632d2f9d63d0008d24182
😎 Deploy Preview https://deploy-preview-1518--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62f632d2f532a60009e8fe79
😎 Deploy Preview https://deploy-preview-1518--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Aug 12, 2022
@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62f632d21a8f33000980cd26
😎 Deploy Preview https://deploy-preview-1518--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62f632d24e74f10009c3b892
😎 Deploy Preview https://deploy-preview-1518--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/62f632d2fd16d60008e7dca1
😎 Deploy Preview https://deploy-preview-1518--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62f632d281a3060008f80a26
😎 Deploy Preview https://deploy-preview-1518--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62f632d22e43b00008cfb739
😎 Deploy Preview https://deploy-preview-1518--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62f632d2062531000874eea3
😎 Deploy Preview https://deploy-preview-1518--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62f632d2fc4d0600098a6936
😎 Deploy Preview https://deploy-preview-1518--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 2573d90
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62f632d2f9d63d0008d24187
😎 Deploy Preview https://deploy-preview-1518--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Aug 12, 2022 •
edited
Loading


Test summary

22 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-default-demo
Status Passed
Commit 1170a92 ℹ️
Started Aug 12, 2022 10:05 AM
Ended Aug 12, 2022 10:06 AM
Duration 01:26 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Aug 12, 2022 •
edited
Loading


Test summary

2 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 1170a92 ℹ️
Started Aug 12, 2022 10:05 AM
Ended Aug 12, 2022 10:07 AM
Duration 01:15 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Aug 12, 2022 •
edited
Loading


Test summary

7 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-static-demo
Status Passed
Commit 1170a92 ℹ️
Started Aug 12, 2022 10:07 AM
Ended Aug 12, 2022 10:08 AM
Duration 01:20 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ascorbic ascorbic self-assigned this Aug 12, 2022
MarcL
MarcL approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@MarcL MarcL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks for sorting this. 👍🏻

@kodiakhq kodiakhq bot merged commit d65f75c into main Aug 12, 2022
@kodiakhq kodiakhq bot deleted the mk/move-plugin branch August 12, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcL MarcL MarcL approved these changes

Assignees

@ascorbic ascorbic

Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @MarcL