Skip to content

feat(build): add BuildOptions#minify to enable code minification #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 27, 2024

Default to !BuildOptions#debug

This will be useful for cloudflare as we don't want to minify the code to be able to apply string replace patches (see this issue)

With this change, we can decide not to minify the code whether or not debug is enabled (by overriding the BuildOptions).

Notes:

  • wrangler will ultimately minify the code anyway
  • we plan to migrate the patches to AST transforms to not depend on whether or not the code is minified

@vicb vicb requested a review from conico974 November 27, 2024 19:37
Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 9edd647

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.73% 1723 / 7579
🔵 Statements 22.73% 1723 / 7579
🔵 Functions 55.73% 102 / 183
🔵 Branches 70.73% 435 / 615
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/bundleNextServer.ts 0% 0% 0% 0% 1-108
packages/open-next/src/build/createServerBundle.ts 0% 0% 0% 0% 1-315
packages/open-next/src/build/helper.ts 0% 0% 0% 0% 1-380
packages/open-next/src/build/edge/createEdgeBundle.ts 0% 0% 0% 0% 1-241
Generated in workflow #792 for commit 9edd647 by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Nov 27, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@655

commit: 9edd647

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb
Copy link
Contributor Author

vicb commented Nov 28, 2024

Thanks for the review!

@vicb vicb merged commit cdcaa97 into main Nov 28, 2024
3 checks passed
@vicb vicb deleted the minify branch November 28, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants